fix: Only look for blueprints on generate from our blueprint directory. #308

hansl · 2016-03-17T21:14:16Z

Fixes #266

filipesilva · 2016-03-17T21:22:47Z

addon/ng2/commands/generate.ts

+  name: 'generate',
+
+  lookupBlueprint: function(name) {
+    return Blueprint.lookup(name, {


Missing import of Blueprint, I believe.

filipesilva · 2016-03-17T23:52:10Z

This PR will block all blueprints that are not in this repo, which does block unsupported blueprints from ember-cli but will also block blueprints from angular-cli addons.

hansl · 2016-03-17T23:53:27Z

It's okay for now, when we release we'll have to revisit blueprints.

Fixes angular#266

angular-automatic-lock-bot · 2019-09-09T22:41:46Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

filipesilva reviewed Mar 17, 2016
View reviewed changes

hansl force-pushed the issue266-generate-model branch 2 times, most recently from 32bad75 to be77c9c Compare March 17, 2016 23:07

hansl force-pushed the issue266-generate-model branch from be77c9c to d20951e Compare March 17, 2016 23:54

fix: Only look for blueprints on generate from our blueprint directory.

d3649d5

Fixes angular#266

hansl force-pushed the issue266-generate-model branch from d20951e to d3649d5 Compare March 17, 2016 23:54

hansl merged commit d3649d5 into angular:master Mar 18, 2016

filipesilva added the pr_state: LGTM label Mar 18, 2016

hansl deleted the issue266-generate-model branch March 31, 2016 18:10

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Only look for blueprints on generate from our blueprint directory. #308

fix: Only look for blueprints on generate from our blueprint directory. #308

hansl commented Mar 17, 2016

filipesilva Mar 17, 2016

hansl Mar 17, 2016

filipesilva commented Mar 17, 2016

hansl commented Mar 17, 2016

angular-automatic-lock-bot bot commented Sep 9, 2019

fix: Only look for blueprints on generate from our blueprint directory. #308

fix: Only look for blueprints on generate from our blueprint directory. #308

Conversation

hansl commented Mar 17, 2016

filipesilva Mar 17, 2016

Choose a reason for hiding this comment

hansl Mar 17, 2016

Choose a reason for hiding this comment

filipesilva commented Mar 17, 2016

hansl commented Mar 17, 2016

angular-automatic-lock-bot bot commented Sep 9, 2019